Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional layers #32

Closed
wants to merge 70 commits into from

Conversation

moben
Copy link

@moben moben commented Jun 11, 2021

For any layers A, B, ... specified via MIRYOKU_EXTRA_LAYERS (up to 8),

[A] = LAYOUT_miryoku(MIRYOKU_TABLE_A),
[B] = LAYOUT_miryoku(MIRYOKU_TABLE_B),
...

will be added between the base layer and the top miryoku layers.

The tables can either be defined by the user or the tables that miryoku
defines can be used by specifying e.g. 'QWERTY' for a qwerty layer.

Fixes manna-harbour/miryoku#17

Looking forward to what you think of this approach. It's quite flexible from my initial experience and didn't require too much preprocessor hackery to get working.

I didn't touch the "upper" layers as I feel swapping in an extra flipped MEDIA layer is less useful than other layouts or user defined layers but it would be a simple mechanical change to add defines for the other layers. I'm just not sure how qmk handles it if the thumb key that switches the layer is remapped on the target layer.

manna-harbour and others added 13 commits February 13, 2021 21:54
Resolves qmk#16

Co-authored-by: Manna Harbour <51143715+manna-harbour@users.noreply.github.com>
* Adds support for python3, still compatible with python2.
* Resolves qmk#10
* Resolves qmk#19

Co-authored-by: Ori <ori@oribarbut.com>
Co-authored-by: Manna Harbour <51143715+manna-harbour@users.noreply.github.com>
resolves qmk#11
resolves qmk#12

Co-authored-by: RubioJr9 <u0893472@utah.edu>
 - Separate tap_table into alphas_table and thumbs_table
 - Add mode argument to table-layout-half
 - Remove layer_name
 - Rename layers
 - Add mods and clipboard to MBO and mirror
 - Add MIRYOKU_LAYERS=FLIP
 - Add MIRYOKU_NAV=INVERTEDT
For any layers A, B, ... specified via MIRYOKU_EXTRA_LAYERS (up to 8),

  [A] = LAYOUT_miryoku(MIRYOKU_TABLE_A),
  [B] = LAYOUT_miryoku(MIRYOKU_TABLE_B),
  ...

will be added between the base layer and the top miryoku layers.

The tables can either be defined by the user or the tables that miryoku
defines can be used by specifying e.g. 'QWERTY' for a qwerty layer.
@moben moben force-pushed the miryoku_extra_layers branch from f48cd13 to 6f615f0 Compare June 11, 2021 20:20
@moben
Copy link
Author

moben commented Jun 11, 2021

Writing out the #define MIRYOKU_TABLE_... in the org source feels a bit verbose, I'll look at how to generate them better with babel while rebasing #24

@manna-harbour
Copy link
Owner

Very nice!

Unfortunately I won't be making any more changes until after the Miryoku reorganisation, as the babel stuff is being split off to better support other implementations. Then I'll probably start with moving all the array contents into #defines in the .h as you've done for Base. That'll make things cleaner anyway and might open up some possibilities for direct use from outside. If you wouldn't mind rebasing after that we can revisit this then.

Thanks!

@manna-harbour
Copy link
Owner

Then I'll probably start with moving all the array contents into #defines in the .h as you've done for Base. That'll make things cleaner anyway and might open up some possibilities for direct use from outside

This has been done now with the move to Miryoku Babel. It can be used to easily substitute layers: manna-harbour/miryoku#47.

@manna-harbour
Copy link
Owner

Support for adding custom layers and removing layers has been added. See manna-harbour/miryoku#48.

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants