-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional layers #32
Conversation
Remove alternative bottom row support from ortho_4x12
Resolves qmk#15
- Separate tap_table into alphas_table and thumbs_table - Add mode argument to table-layout-half - Remove layer_name - Rename layers - Add mods and clipboard to MBO and mirror - Add MIRYOKU_LAYERS=FLIP - Add MIRYOKU_NAV=INVERTEDT
For any layers A, B, ... specified via MIRYOKU_EXTRA_LAYERS (up to 8), [A] = LAYOUT_miryoku(MIRYOKU_TABLE_A), [B] = LAYOUT_miryoku(MIRYOKU_TABLE_B), ... will be added between the base layer and the top miryoku layers. The tables can either be defined by the user or the tables that miryoku defines can be used by specifying e.g. 'QWERTY' for a qwerty layer.
f48cd13
to
6f615f0
Compare
Writing out the |
Very nice! Unfortunately I won't be making any more changes until after the Miryoku reorganisation, as the babel stuff is being split off to better support other implementations. Then I'll probably start with moving all the array contents into Thanks! |
aaa0ce7
to
7cc8b32
Compare
This has been done now with the move to Miryoku Babel. It can be used to easily substitute layers: manna-harbour/miryoku#47. |
36635c2
to
7cc8b32
Compare
Support for adding custom layers and removing layers has been added. See manna-harbour/miryoku#48. Thanks again for the PR! |
For any layers A, B, ... specified via MIRYOKU_EXTRA_LAYERS (up to 8),
[A] = LAYOUT_miryoku(MIRYOKU_TABLE_A),
[B] = LAYOUT_miryoku(MIRYOKU_TABLE_B),
...
will be added between the base layer and the top miryoku layers.
The tables can either be defined by the user or the tables that miryoku
defines can be used by specifying e.g. 'QWERTY' for a qwerty layer.
Fixes manna-harbour/miryoku#17
Looking forward to what you think of this approach. It's quite flexible from my initial experience and didn't require too much preprocessor hackery to get working.
I didn't touch the "upper" layers as I feel swapping in an extra flipped MEDIA layer is less useful than other layouts or user defined layers but it would be a simple mechanical change to add defines for the other layers. I'm just not sure how qmk handles it if the thumb key that switches the layer is remapped on the target layer.