Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme should include apply plugin for legacy syntax #313

Closed
peterdk opened this issue Feb 4, 2024 · 1 comment · Fixed by #315
Closed

Readme should include apply plugin for legacy syntax #313

peterdk opened this issue Feb 4, 2024 · 1 comment · Fixed by #315

Comments

@peterdk
Copy link
Contributor

peterdk commented Feb 4, 2024

I was struggling to get my Junit5 tests detected, and it turned out that the readme didn't tell me to actually:

apply plugin: 'de.mannodermaus.android-junit5'

I am using the legacy Gradle setup, and this is not mentioned there.
When I do not apply the plugin in my target build.gradle then it won't find the junit 5 tests.

I'll look if I can make a PR for adding this, since it took me an hour to figure out.
@peterdk peterdk mentioned this issue Feb 4, 2024
Closed
mannodermaus added a commit that referenced this issue Feb 10, 2024
@mannodermaus
Update readme to make it more clear that you need to apply plugin als…
05ec61b 
…o in legacy syntax

Closes #313

Co-authored-by: "Peter de Kraker <peterdekraker@umito.nl>"
mannodermaus added a commit that referenced this issue Feb 10, 2024
@mannodermaus @peterdk
Update readme to make it more clear that you need to apply plugin als…
2f3d1b7 
…o in legacy syntax

Closes #313

Co-authored-by: Peter de Kraker <peterdekraker@umito.nl>
@mannodermaus mannodermaus mentioned this issue Feb 10, 2024
Merged
@mannodermaus
Copy link
Owner

Thanks for reporting. It makes sense to include the apply statement for legacy Groovy clients. Thank you as well for preparing a PR! I took it and reorganized the contents into a single block per language, as I prefer that over the multi-block approach. I'll merge #315 once CI clears it!

mannodermaus added a commit that referenced this issue Feb 10, 2024
@mannodermaus @peterdk
Update readme to make it more clear that you need to apply plugin als…
a70cc09 
…o in legacy syntax (#315)

Closes #313

Co-authored-by: Peter de Kraker <peterdekraker@umito.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peterdk @mannodermaus