Add unavailable reason to BluetoothError error #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolofdez
reviewed
Dec 16, 2023
Tests/CentralManagerUtilsTests.swift
Outdated
|
|
||
| class CentralManagerUtilsTests: XCTestCase { | ||
| func testIsBluetoothReady() throws { | ||
| XCTAssert(true) |
There was a problem hiding this comment.
DOH! Thanks for catching that. It is removed now
|
Looks great to me! Just one minor comment. |
litso
force-pushed
the
add-unavailable-reason
branch
from
dce5016 to
e363988
Compare
manolofdez
approved these changes
Dec 27, 2023
|
Thanks for taking this on and contributing! |
andrewash
added a commit
to pbsupplyco/AsyncBluetooth
that referenced
this pull request
May 28, 2024
* parent/main: [Feature] Add the privacy manifest manolofdez#49 [Feature] Allow logs to be disabled (manolofdez#47) [Feature] Add BluetoothError error reasons (manolofdez#42) [Feature] Add support for reconnection delegate [DOCS] Add setNotifyValue to README [Bugfix] Fix reading crashing updating executors from different threads (manolofdez#38) # Conflicts: # Sources/CentralManager/CentralManager.swift # Sources/Peripheral/BluetoothError.swift # Sources/Peripheral/Peripheral.swift # Sources/Peripheral/PeripheralDelegate.swift # Sources/Utils/AsyncBluetoothLogging.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
BluetoothUnavailableReasonenum.In order to inform a user of a possible remedy for enabling BlueTooth functionality it is useful for the app to know why BlueTooth is unavailable, for example, to prompt to open the Settings app and enable the permission.