Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter console broken #35461

Closed
thomashampson opened this issue Apr 17, 2023 · 1 comment · Fixed by #35463
Closed

Jupyter console broken #35461

thomashampson opened this issue Apr 17, 2023 · 1 comment · Fixed by #35463
Labels
Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone

Comments

@thomashampson
Copy link
Contributor

thomashampson commented Apr 17, 2023

Describe the bug
Jupyter console does not seem to be working very well on recent Conda installs (including on IDAaaS). Trying to run anything at all results in this kind of error:

        Stack Trace:
        Traceback (most recent call last):
  File "/opt/mantidworkbench6.6/lib/python3.8/site-packages/qtconsole/base_frontend_mixin.py", line 138, in _dispatch
    handler(msg)
  File "/opt/mantidworkbench6.6/lib/python3.8/site-packages/qtconsole/jupyter_widget.py", line 193, in _handle_execute_reply
    super()._handle_execute_reply(msg)
  File "/opt/mantidworkbench6.6/lib/python3.8/site-packages/qtconsole/frontend_widget.py", line 468, in _handle_execute_reply
    if not self.kernel_client.iopub_channel.closed():
AttributeError: 'QtInProcessChannel' object has no attribute 'closed'

Afterwards it is completely unuseable.

I have narrowed this down to an upgrade of our qtconsole dependency. It seems to have broken with v5.4.2, I think due to this PR:
jupyter/qtconsole#574

To Reproduce

  1. Install mantidworkbench into a new Conda environment.
  2. Type anything (e.g. i = 1) into the Jupyter console and press return. It will pop up the error reporter.

Expected behavior
It should work.

Platform/Version (please complete the following information):

  • OS: Any
  • Mantid Version: any installed from Conda with qtconsole==5.4.2

Additional context
This will likely be fixed by this open PR in the qtconsole repo jupyter/qtconsole#575 but in the meantime we should pin to 5.4.1 so that the nightly version works.

@thomashampson thomashampson added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Linux Only Only on Linux labels Apr 17, 2023
@thomashampson thomashampson added this to the Release 6.7 milestone Apr 17, 2023
@thomashampson thomashampson added the Added during Sprint Tasks that were added after initial sprint planning label Apr 17, 2023
@thomashampson thomashampson changed the title Jupyter console broken on IDAaaS Jupyter console broken on Linux Apr 18, 2023
@thomashampson thomashampson changed the title Jupyter console broken on Linux Jupyter console broken Apr 18, 2023
@thomashampson thomashampson added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. and removed Linux Only Only on Linux labels Apr 18, 2023
@peterfpeterson
Copy link
Member

@zjmorgan pointed this out at ORNL as well.

Notes from @AndreiSavici is that v6.6 vs nightly are using

v6.6: Jupyter QtConsole 5.4.0, IPython 8.11.0.
In nightly: Jupyter QtConsole 5.4.2, IPython 8.12.0

The bug that exists in v5.4.2 is fixed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants