Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the iopub channel is not closed before flushing it #574

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

ccordoba12
Copy link
Collaborator

This is necessary to avoid the error reported in spyder-ide/spyder#20381 (comment).

@ccordoba12 ccordoba12 added this to the 5.4.2 milestone Mar 29, 2023
@ccordoba12 ccordoba12 self-assigned this Mar 29, 2023
@ccordoba12
Copy link
Collaborator Author

@minrk, this is the kind of check you suggested in your spyder-ide/spyder#20381 (comment), right? Just checking to be sure because this is a bit above my paygrade.

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's exactly what I was talking about.

qtconsole/client.py Outdated Show resolved Hide resolved
Co-authored-by: Min RK <benjaminrk@gmail.com>
@ccordoba12 ccordoba12 merged commit 5a341e1 into jupyter:master Mar 30, 2023
@ccordoba12 ccordoba12 deleted the check-closed-before-flushing branch March 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants