Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bad validation in AddSampleLogMultiple #34566

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Oct 18, 2022

Description of work.

Fixed a typo in AddSampleLogMultiple which caused a crash when reporting an issue where the parse type box was ticked and log types were supplied.

To test:

Fixes #34553


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@MialLewis MialLewis self-assigned this Oct 19, 2022
Copy link
Contributor

@MialLewis MialLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works, bug no longer present.

@gemmaguest gemmaguest merged commit 3295eeb into main Oct 21, 2022
@gemmaguest gemmaguest deleted the 34553_fix_AddSampleLogMultiple_validation branch October 21, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddSampleLogMultiple invalid LogType closes workbench
3 participants