Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend drive to jenkins workspace if missing on VM agents #35313

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

thomashampson
Copy link
Contributor

Description of work.
The WORKSPACE variable used in the nightly pipeline Jenkinsfile is missing the C: on cloud VM Windows nodes. Here it is prepended if it's not there.

To test:

Verify that this job passed all build/test and package steps:
https://builds.mantidproject.org/job/build_packages_from_branch/249/

Fixes #35119

This does not require release notes because it's a change to our build config


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@thomashampson thomashampson added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Windows Only Only on Windows DevOps Issues and pull requests related to DevOps labels Feb 27, 2023
@thomashampson thomashampson added this to the Release 6.7 milestone Feb 27, 2023
Copy link
Contributor

@MialLewis MialLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, build package test has passed.

@thomashampson thomashampson marked this pull request as ready for review February 28, 2023 09:45
@gemmaguest gemmaguest merged commit f28a2ee into main Feb 28, 2023
@gemmaguest gemmaguest deleted the 35119_windows_vm_pipeline_fix branch February 28, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Windows Only Only on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Windows cloud VM compatibility with jenkins pipeline
3 participants