Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System Tests for Spectrum Viewer Features #2322

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ashmeigh
Copy link
Collaborator

Issue

Closes #2320

Description

This pull request introduces unit tests for the Spectrum Viewer features. The changes focus on ensuring that all key functionalities related to Regions of Interest (ROIs) in the Spectrum Viewer are thoroughly tested.

ROIs Management: Tests for adding, removing, and renaming ROIs.

ROI Adjustments: Tests for adjusting the position and size of ROIs.

ROI Color: Tests for changing the color of ROIs.

Normalization Toggle: Tests for toggling normalization on and off.

Data Export: Tests for exporting data to CSV and RITS formats.

Documentation

Release Notes: Added a note in the docs/release_notes about the new

@coveralls
Copy link

coveralls commented Aug 20, 2024

Coverage Status

coverage: 74.337%. remained the same
when pulling c54e2dd on 2320_Enhance_System_Tests_for_Spectrum_Viewer
into 0948a45 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are useful, but a few a of them need to step back a level so that they are exercising the gui more than what could be done in unit tests.

mantidimaging/gui/test/gui_system_spectrum_test.py Outdated Show resolved Hide resolved
mantidimaging/gui/test/gui_system_spectrum_test.py Outdated Show resolved Hide resolved
mantidimaging/gui/test/gui_system_spectrum_test.py Outdated Show resolved Hide resolved
mantidimaging/gui/test/gui_system_spectrum_test.py Outdated Show resolved Hide resolved
- Added tests for adding, removing, renaming, and adjusting ROIs
- Implemented tests for changing ROI color and toggling normalization
@samtygier-stfc samtygier-stfc force-pushed the 2320_Enhance_System_Tests_for_Spectrum_Viewer branch from b4967f6 to c54e2dd Compare September 12, 2024 15:54
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I squashed the commits to remove the merges and some churn from adding and removing things.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 1d27e84 Sep 12, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2320_Enhance_System_Tests_for_Spectrum_Viewer branch September 12, 2024 16:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance System Tests for Spectrum Viewer
3 participants