Added stack properties dialog in the Main Window #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
2368_stack_properties_menu
branch
2 times, most recently
from
bb53906 to
0402a71
Compare
MikeSullivan7
changed the title
samtygier-stfc
requested changes
Jan 21, 2025
MikeSullivan7
force-pushed
the
2368_stack_properties_menu
branch
from
0459daa to
5174a20
Compare
samtygier-stfc
requested changes
Feb 12, 2025
…ck_data_set_correctly
MikeSullivan7
force-pushed
the
2368_stack_properties_menu
branch
from
624db20 to
6f31502
Compare
samtygier-stfc
requested changes
Feb 18, 2025
| super().__init__(view) | ||
|
|
||
| def set_stack_data(self) -> None: | ||
| if self.view.stack is not None: |
There was a problem hiding this comment.
Not sure if this is from a mypy suggestion or older version of the code.
If self.view.stack is None then something has gone wrong (e.g. side bar has got out of sync), so I don't think it should be silently ignored here.
It might be better handled with an assert self.stack is not None in the view, so that the rest of the dialog can assume that it is set. Or this and the call to get_images_by_uuid() could move into the main window.
| self.view.stack_shape = self.view.stack.data.shape | ||
| self.view.stack_size_MB = self.get_stack_size_MB() | ||
|
|
||
| def set_stack_directory(self): |
| @@ -683,6 +687,10 @@ def _move_stack(self) -> None: | |||
| stack_id = self.dataset_tree_widget.selectedItems()[0].id | |||
| self.presenter.notify(PresNotification.SHOW_MOVE_STACK_DIALOG, stack_id=stack_id) | |||
|
|
|||
| def _stack_properties(self): | |||
| @@ -109,6 +110,7 @@ class MainWindowView(BaseMainWindowView): | |||
| nexus_save_dialog: NexusSaveDialog | None = None | |||
| add_to_dataset_dialog: AddImagesToDatasetDialog | None = None | |||
| move_stack_dialog: MoveStackDialog | None = None | |||
| stack_properties_dialog: StackPropertiesDialog | None = None | |||
There was a problem hiding this comment.
This is no longer needed, I think its left over from when there was a self.stack_properties_dialog
Comment on lines
+9
to
+10
| from mantidimaging.core.data import ImageStack | ||
| from mantidimaging.core.data.dataset import Dataset |
There was a problem hiding this comment.
These could be in a if TYPE_CHECKING:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2368
Description
Added a custom dialog window which can be accessed by right clicking a stack in the main window and clicking on "Stack properties". This gives information on the stack e.g, Dataset name, File Path, Data type, Memory size, Shape, Log file. More information can be added if needed.
Testing
Make check
Acceptance Criteria
Load a dataset into MI and open the Stack Properties dialog window via the right click window. Check that all the information displayed is correct and that no errors occur