Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT REVIEW 2378 Part Three: Return of the ROIFormWidget Class - Represent ROI: Export Tabs, Action Buttons, Table & Properties #2495

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JackEAllen
Copy link
Collaborator

Issue Contributes to: #2378

Description

The proposed changes moves ROITableWidget, ROIPropertiesTableWidget, ROI export tabs and ROI action buttons into the class ROIFormWidget which will eventually act as the main interface for all these components when called within SpectrumViewerWindowView. This change is in preparation for extraction of the related xml GUI code out of spectrum_viewer.ui and into mantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.ui and ROIFormWidget into mantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.py

Developer Testing

  • I have verified unit tests pass locally: python -m pytest -vs
  • I have manually tested the Spectrum Viewer ROI table and properties remain up to date when:
    • Creating new ROIs
    • Renaming ROIs
    • Removing ROIs
    • Selecting an ROI with the intention to rename, then selecting another ROI
    • Swapping tabs between ROI and Image tabs
    • Toggling ROI visibility for various ROIs
    • Toggling ROI visibility and swapping between Image and ROI tab views.

Acceptance Criteria and Reviewer Testing

  • Unit tests pass locally: python -m pytest -vs
  • ROI Properties table values always display the selected ROI
  • ROI table state remains up to date/in-sync with state of ROIs when adding, renaming and removing ROIs.
  • The Selected ROI can only be a visible ROI
  • No change in functional behaviour is introduced when compared to main branch.

Documentation and Additional Notes

Release notes are not needed as they will be added as part of the final PR completing the work described by #2378

@JackEAllen JackEAllen self-assigned this Feb 10, 2025
@JackEAllen JackEAllen changed the title 2378 Part Three: Return of the ROIFormWidget Class - Represent ROI: Export Tabs, Action Buttons, Table & Properties DO NOT REVIEW 2378 Part Three: Return of the ROIFormWidget Class - Represent ROI: Export Tabs, Action Buttons, Table & Properties Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant