DO NOT REVIEW 2378 Part Three: Return of the ROIFormWidget Class - Represent ROI: Export Tabs, Action Buttons, Table & Properties #2495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Contributes to: #2378
Description
The proposed changes moves
ROITableWidget
,ROIPropertiesTableWidget
, ROI export tabs and ROI action buttons into the class ROIFormWidget which will eventually act as the main interface for all these components when called withinSpectrumViewerWindowView
. This change is in preparation for extraction of the related xml GUI code out ofspectrum_viewer.ui
and intomantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.ui
andROIFormWidget
intomantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.py
Developer Testing
python -m pytest -vs
Acceptance Criteria and Reviewer Testing
python -m pytest -vs
Documentation and Additional Notes
Release notes are not needed as they will be added as part of the final PR completing the work described by #2378