DO NOT REVIEW 2378 Part Four: The Phantom XML - Extract ROIFormWidget into Widgets Sub-directory

[JackEAllen]

Issue Closes #2378

Description

The proposed changes extracts the xml GUI code out of spectrum_viewer.ui and into mantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.ui and ROIFormWidget into mantidimaging/gui/widgets/spectrum_widgets/ROIFORMWidget.py

Developer Testing

• I have verified unit tests pass locally: python -m pytest -vs
• I have manually tested the Spectrum Viewer ROI properties remain up to date when:
  • Creating new ROIs
  • Renaming ROIs
  • Removing ROIs
  • Selecting an ROI with the intention to rename, then selecting another ROI
  • Swapping tabs between ROI and Image tabs
  • Toggling ROI visibility for various ROIs
  • Toggling ROI visibility and swapping between Image and ROI tab views.

Acceptance Criteria and Reviewer Testing

• Unit tests pass locally: python -m pytest -vs
• ROI Properties table values always display the selected ROI
• ROI table state remains up to date/in-sync with state of ROIs when adding, renaming and removing ROIs.
• The Selected ROI can only be a visible ROI
• No change in functional behaviour is introduced when compared to main branch.

Documentation and Additional Notes

• Release Notes have been updated

[coveralls]

coverage: 73.075%. remained the same
when pulling 055b399 on 2378_PART_FOUR_extract_ROIFORMWidget_into_widgets
into dbede8a on main.