Refactor of ROIPropertiesTableWidget #2500
Open
+154
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define layout with a grid layout instead of a table
And move the changing into the class
No where outside class has direct access to spinboxes any more. Remove dicts of widgets Use explict access to widgets, so it is impossible for properties to be in the wrong order Remove unused function
|
This causes some small changes to the layout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #2378
Also closes #2499 (I think the issue was due to nested tables in the layout making Qt unhappy)
Description
Now that ROIPropertiesTableWidget is split into its own class, it is easier to make some refactoring.
This PR:
Does the layout for ROIPropertiesTableWidget with a .ui file
Moves all access to internal widgets into the class, with high level access functions (e.g.
set_roi_limits())Uses explicit widget names, rather than looping over keys to make any ordering difference bugs impossible
Developer Testing
make checkandmake test-systemAcceptance Criteria and Reviewer Testing
Note changes are split into commits for easier reviewing
Documentation and Additional Notes
Does not need release notes as part of bigger work
Will have some screenshot changes