Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in overwriting style properties between Menu and Popover #7120

Closed
1 of 2 tasks
MartinMuzatko opened this issue Nov 14, 2024 · 1 comment
Closed
1 of 2 tasks
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@MartinMuzatko
Copy link
Contributor

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.14.0

What package has an issue?

@mantine/core

What framework do you use?

Next.js

In which browsers you can reproduce the issue?

All

Describe the bug

In the Menu component, I can overwrite the top and left styles in the styles.dropdown prop of the Menu oder the Menu.Dropdown, or I can set the style in Menu.Dropdown.

However in the Popover component, the only way to overwrite these styles already set by the component is to use the Popover.Dropdown style prop.

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/mantine-react-template-forked-x7rmkj

Possible fix

I haven't checked the code out yet, but I believe there is an inconsistency with how the props are rendered or what the order of writing to the style is.

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Nov 16, 2024
@rtivital
Copy link
Member

Fixed in 7.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants