This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Fix bit rot in mesos-go API and Consul dependencies #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves the same issue that #112 does but does it in a different way. Either method works. |
|
|
|
#112 was merged in which accomplishes the same thing, we may be able to just close this out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mesos-go has moved to a different API, but were kind enough to leave the old one in place, so I've monkey-patched this issue.
Consul API requires Go >=1.7 to build, but Alpine 3.1 had Go 1.3.3; I've updated Dockerfile to point towards Alpine 3.5 with Go 1.7.3.
A certain kernel bug in overlayfs does not allow removing a file created in another layer (cf. moby/moby#27214). Added a workaround for that.