Use AppVeyor artifact URLs in manuscript front-matter #263
Conversation
|
AppVeyor build 1.0.24 for commit 7d1c827 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at |
|
The updated conda version to have shaved aboutr 32 seconds off build time in terms of environment installation. |
|
AppVeyor build 1.0.25 for commit 0fd41ae by @dhimmel failed. |
dhimmel
force-pushed
the
appveyor-variables
branch
from
0fd41ae
to
1f541a8
Compare
|
AppVeyor build 1.0.26 for commit 1f541a8 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at |
content/00.front-matter.md
Outdated
| @@ -12,7 +12,7 @@ _A DOI-citable version of this manuscript is available at <https://doi.org/DOI_H | |||
| <small><em> | |||
| This manuscript | |||
| {% if ci_source is defined -%} | |||
There was a problem hiding this comment.
Because ci_source.manuscript_url is created in a separate Manubot function add_manuscript_urls_to_ci_params, should we also ensure that ci_source.manuscript_url is defined here? Or only check for ci_source.manuscript_url?
There was a problem hiding this comment.
I don't think ci_params will ever exist without manuscript_url with the current manubot software because:
But it doesn't hurt to be safe and possibly some users will have an outdated manubot python package with this version of content/00.front-matter.md , so I added the extra check in b07d870
| @@ -12,7 +12,7 @@ _A DOI-citable version of this manuscript is available at <https://doi.org/DOI_H | |||
| <small><em> | |||
| This manuscript | |||
| {% if ci_source is defined -%} | |||
| ([permalink](https://{{ci_source.repo_owner}}.github.io/{{ci_source.repo_name}}/v/{{ci_source.commit}}/)) | |||
| ([permalink]({{ci_source.manuscript_url}})) | |||
| {% endif -%} | |||
| was automatically generated | |||
| {% if ci_source is defined -%} | |||
There was a problem hiding this comment.
It's not obvious to me which commit we should show in line 19 below for AppVeyor builds. The manuscript filename contains the triggering commit, but this link contains the merge commit for a pull request build. However, the triggering commit doesn't correspond to the ci_source.repo_slug tree. It resides in the tree of the forked repository.
I don't see a better option that what is already here. I do expect the difference between the filename and link could cause confusion.
There was a problem hiding this comment.
Yes it is confusing, but I think it's important that the manuscript contains the commit that actually created it.
|
AppVeyor build 1.0.27 for commit b07d870 by @dhimmel is now complete. The rendered manuscript from this build is temporarily available for download at |
This build is based on 6a3ac95. This commit was created by the following Travis CI build and job: https://travis-ci.com/manubot/rootstock/builds/125258958 https://travis-ci.com/manubot/rootstock/jobs/229678954 The full commit message that triggered this build is copied below: Use AppVeyor artifact URLs in manuscript front-matter Merges #263 Update front-matter to use ci_source.manuscript_url Update environment on 2019-08-09
This build is based on 6a3ac95. This commit was created by the following Travis CI build and job: https://travis-ci.com/manubot/rootstock/builds/125258958 https://travis-ci.com/manubot/rootstock/jobs/229678954 The full commit message that triggered this build is copied below: Use AppVeyor artifact URLs in manuscript front-matter Merges #263 Update front-matter to use ci_source.manuscript_url Update environment on 2019-08-09
Merges manubot/rootstock#263 Update front-matter to use ci_source.manuscript_url Update environment on 2019-08-09
Merges manubot/rootstock#263 Update front-matter to use ci_source.manuscript_url Update environment on 2019-08-09
Follows up on #262 (comment)
Refs #198