Fix duplex ADF #1088
Merged
Fix duplex ADF #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been tested to work against 9019e in platen, ADF and duplex ADF modes, where previously the duplex ADF failed in 1.6.1 |
manuc66
reviewed
Jan 28, 2025
Dead code path for devices without scanToComp, as this will be exercised later when registration occurs
|
I have refactored it but the CodeFactor page still links to the previous commit when showing the alert, so might need a restart. Weirdly the complexity factor is supposedly derived from the number of paths through the function and that original one line addition added no new paths, so I don't know why this tripped in the first place when it wasn't before... |
|
Fix released @aaliddell thank you very much for this fix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1087 by reading the ADF duplexer capabilities and using that if available