Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mapping : shortcut to output document type #569

Merged
merged 3 commits into from
Oct 22, 2022

Conversation

manuc66
Copy link
Owner

@manuc66 manuc66 commented Oct 22, 2022

Hope to fix : #568

@hendrik1120 Could you test this PR ?

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Base: 82.77% // Head: 83.20% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (d9b6eaf) compared to base (00ef44d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   82.77%   83.20%   +0.42%     
==========================================
  Files          17       17              
  Lines         389      387       -2     
  Branches       64       62       -2     
==========================================
  Hits          322      322              
  Misses         37       37              
+ Partials       30       28       -2     
Impacted Files Coverage Δ
src/WalkupScanToCompDestination.ts 94.44% <ø> (+4.97%) ⬆️
src/WalkupScanDestination.ts 100.00% <100.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hendrik1120
Copy link

Yes, I now get PDFs in the output instead of jpgs.

Thank you so much for this very quick fix!

You can add the printer to the compatible list as well if you want.
The scan quality looks decent and I haven't noticed any other issues so far.

@manuc66 manuc66 merged commit a61045d into master Oct 22, 2022
manuc66 added a commit that referenced this pull request Oct 22, 2022
Add HP Deskjet 3050 All-in-One Printer - J610a
See #569
@manuc66 manuc66 deleted the feature/wrongly_only_jpg branch November 30, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deskjet 3050 All-in-One J610a only jpg
2 participants