add environment variables to docker entrypoint #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekonnection
force-pushed
the
add_envvars
branch
2 times, most recently
from
fd8cab4 to
d0332d8
Compare
dekonnection
force-pushed
the
add_envvars
branch
from
d0332d8 to
32e7b59
Compare
manuc66
reviewed
Oct 30, 2023
|
Oh yes, I forgot that, will do :) |
|
I added the following things to the README:
I reordered a thing or two, of course modify it or let me know if it's not to your taste 👍 |
|
Thanks you @dekonnection ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks a lot for this program !
It works perfectly with my OfficeJet 3830.
SInce I'm using it with K8s, I found that some useful parameters were missing in the docker entrypoint (like for setting the resolution, etc.), this PR just adds that :)
Have a great day