Feature/support full scan size #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying for the scanner capabilities capture the full height and width for both the platen and ADF. Then pass these as the height and width for the job settings and update the job XML. This allows for scans to scan up to the full size available for the input source rather than the hard-coded size that was previously used. This PR also removes the 33 pixel cutoff from the X axis.
# Conflicts: # src/ScanJobSettings.ts # src/scanProcessing.ts
manuc66
force-pushed
the
feature/support-full-scan-size
branch
from
01cfaa7 to
d633250
Compare
…into feature/support-full-scan-size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvinf the work proposed by @cbisnett