Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from deprecated node-sass to Dart Sass #222

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

brianclinkenbeard
Copy link
Contributor

@brianclinkenbeard brianclinkenbeard commented Nov 15, 2023

Node Sass is deprecated, and I wasn't able to build the project with NodeJS 18 without switching to the Dart Sass (sass) package as recommended (and then using --ignore-engines). This PR simply replaces the package in the dependencies.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for weektodo-app ready!

Name Link
🔨 Latest commit 3b336ab
🔍 Latest deploy log https://app.netlify.com/sites/weektodo-app/deploys/65555733de40040007dec92a
😎 Deploy Preview https://deploy-preview-222--weektodo-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@manuelernestog manuelernestog changed the base branch from main to v2.2 February 9, 2024 01:37
@manuelernestog
Copy link
Owner

Nice change @brianclinkenbeard 👏

@manuelernestog manuelernestog merged commit ddfec22 into manuelernestog:v2.2 Feb 9, 2024
4 checks passed
@brianclinkenbeard brianclinkenbeard deleted the fix-sass branch April 11, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants