Added some slovak languages into update SQL #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelselbach
requested changes
May 29, 2018
| @@ -267,3 +267,73 @@ UPDATE static_countries SET cn_short_sk='Západná Sahara' WHERE cn_iso_2='EH'; | |||
| UPDATE static_countries SET cn_short_sk='Jemen' WHERE cn_iso_2='YE'; | |||
| UPDATE static_countries SET cn_short_sk='Zambia' WHERE cn_iso_2='ZM'; | |||
| UPDATE static_countries SET cn_short_sk='Zimbabwe' WHERE cn_iso_2='ZW'; | |||
|
|
|||
|
|
|||
| UPDATE static_languages SET lg_name_sk='albánsky' WHERE uid=4; | |||
There was a problem hiding this comment.
Thanks for the PR, but may I ask you to update the update statements not to use uid but e.g. lg_iso_2='AB' AND lg_country_iso_2='' instead.
Here some further information on that:
https://github.com/manuelselbach/static_info_tables_ru/blob/master/ext_tables_static%2Badt.sql#L927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.