-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous processing #244
Conversation
So I kinda got this to work, but the tricky part is now the correct handling. POST /photosCreate gets called, but it does not create a photo, instead it creates a temporary handle. In the example GET /photos/queue-jobs/5234This call will return 303 See Other when its done. Additionally it contains a Location Header back to the actual Photo that got created. E.g. Location: https://example.com/photos/4577 IMHO api2go does not yet have the functionality to implement such an behaviour. A user can probably fake it after this PR gets merged (without the optional location header) but to implement the suggestion 1:1 we would need a way to respond to Create differently than either Succeed or Error. What do you think @wwwdata? |
RFC for #243 |
bec768a
to
3f77ddc
Compare
Also adds test to reproduce asynch behaviour
so far this looks good in my opinion |
so we are going to merge this for now? |
It cannot hurt to merge it but we should mention something about it in the Readme as well |
TODOs: