feat(storage)!: Throw an error for 403 HTTP responses (#212)

manzt · Oct 1, 2024 · 361a7aa · 361a7aa
1 parent a3c1def
commit 361a7aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/smooth-scissors-end.md b/.changeset/smooth-scissors-end.md
@@ -0,0 +1,5 @@
+---
+"@zarrita/storage": patch
+---
+
+`FetchStore` throws an error for 403 (forbidden) responses. This is a **breaking** change because previously `404` and `403` responses were treated the same way. Now, only `404` responses signify a "missing" key from the store.
diff --git a/packages/storage/src/fetch.ts b/packages/storage/src/fetch.ts
@@ -16,7 +16,7 @@ function resolve(root: string | URL, path: AbsolutePath): URL {
 async function handle_response(
 	response: Response,
 ): Promise<Uint8Array | undefined> {
-	if (response.status === 404 || response.status === 403) {
+	if (response.status === 404) {
 		return undefined;
 	}
 	if (response.status === 200 || response.status === 206) {