Do not rewrite all the notes on the disk when one is deleted

that's still issue #43
maoschanz · Jun 6, 2020 · 8f63ba8 · 8f63ba8
1 parent 2a7d95c
commit 8f63ba8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 28 deletions.
diff --git a/README.md b/README.md
@@ -31,14 +31,15 @@ Notes are stored in files at `~/.local/share/notes@maestroschan.fr/*_text`
 
 <!-- TODO
 
-pas de raise correct quand on focus une note sans focus automatique
+faut réécrire comment ça interagit avec le disque
 
 mettre le putain d'array en attribut du singleton "notesmanager"
 
+pas de raise correct quand on focus une note sans focus automatique
+
 "éditer le titre" dans le menu
 le bouton de grab aurait le titre en label, et clic-droit enroulerait
 
-sa mère faut réécrire comment ça interagit avec le disque, là c'est hoooonteux
 
     -->
 

diff --git a/notes@maestroschan.fr/extension.js b/notes@maestroschan.fr/extension.js
@@ -146,33 +146,17 @@ class NotesManager {
 	}
 
 	/*
-	 * When a NoteBox object deletes itself, it calls this horrible thing to
-	 * ensure the files go from 1 to (ALL_NOTES.length - 1) without any "gap" in
-	 * the numerotation.
+	 * When a NoteBox object deletes itself, it calls this method to ensure the
+	 * files go from 0 to (ALL_NOTES.length - 1) without any "gap" in the
+	 * numerotation.
 	 */
-	postDelete () {
-		// Rebuild a fresh ALL_NOTES array from the existing NoteBox objects
-		let temp = new Array();
-		ALL_NOTES.forEach(function (n) {
-			if (n.actor == null) {
-				// nothing
-			} else {
-				n.id = temp.length;
-				temp.push(n);
-			}
-		});
-		ALL_NOTES = null;
-		ALL_NOTES = temp;
-
-		// Delete the file with the biggest id (the other will be overwritten)
+	postDelete (deletedNoteId) {
+		let lastNote = ALL_NOTES.pop();
+		if (deletedNoteId < ALL_NOTES.length) {
+			ALL_NOTES[deletedNoteId] = lastNote;
+			lastNote.id = deletedNoteId;
+		}
 		this._deleteNoteFiles(ALL_NOTES.length);
-
-		// Save all notes from the ALL_NOTES array to the disk
-		ALL_NOTES.forEach(function (n) {
-			if(n.actor != null) {
-				n.onlySave();
-			}
-		});
 	}
 
 	/*

diff --git a/notes@maestroschan.fr/noteBox.js b/notes@maestroschan.fr/noteBox.js
@@ -661,8 +661,9 @@ var NoteBox = class NoteBox {
 	//--------------------------------------------------------------------------
 
 	_deleteNoteObject () {
+		let noteId = this.id;
 		this.destroy();
-		Extension.NOTES_MANAGER.postDelete();
+		Extension.NOTES_MANAGER.postDelete(noteId);
 	}
 
 	destroy () {