Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to toggle notes' position with a shortcut #65

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

themighty1
Copy link

I had to change use-shortcut to use-visibility-shortcut. Will this break the existing settings for those who upgrade from an earlier version?
if so, I can revert back to the name use-shortcut.

@maoschanz
Copy link
Owner

maoschanz commented Mar 9, 2021

yes i would prefer if the existing keys keep their existing names. Also, "position" means "x y coordinates" to me, this feature is something i named "layers" in the code iirc

i'll merge it because i understand the point of the feature but be aware that i'll likely remove it later, because issue #29 is more interesting in my opinion but it isn't compatible with this

(however don't implement that feature instead please, i need to change several things reliability and performance before doing it)

@themighty1
Copy link
Author

@maoschanz , sure, no problem, I will change the names accordingly. And I will not implement anything else.

@themighty1
Copy link
Author

@maoschanz, names changed, verified to work. Looking forward to your proper fix.

@themighty1
Copy link
Author

@maoschanz , hi, are you happy with this PR?

@maoschanz
Copy link
Owner

it looks fine, i'm just busy with other things so i can't test it right now

@maoschanz maoschanz merged commit 5b4fa39 into maoschanz:master Nov 20, 2021
maoschanz added a commit that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants