Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggleable "Prop Sprinting" Mechanic #236

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

Crimson-X1
Copy link

@Crimson-X1 Crimson-X1 commented Apr 17, 2023

A custom implementation of prop sprinting, as seen in Black Mesa and EZ:2, allows players to sprint while holding a physics object.

This mechanic— disabled by default— is controlled by two new convars: sv_player_enable_propsprint and sv_player_enable_gravgun_sprint.

These convars offer some control over when players can utilize this feature, with the latter convar affecting only the gravity gun.


Does this PR close any issues?

None.

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link
Member

@Blixibon Blixibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little reluctant at first about how well these cvars would fit into Mapbase, but in practice, they are effectively quality-of-life utilities. Mappers and modders can enable or disable them depending on whether they help the gameplay of what they are making.

So the idea behind this feature looks good to me, although I did have a few concerns about the code which I pointed out in this review. I can go ahead and commit the suggestions and merge this myself though.

sp/src/game/server/hl2/weapon_physcannon.cpp Outdated Show resolved Hide resolved
sp/src/game/server/hl2/weapon_physcannon.cpp Outdated Show resolved Hide resolved
@Blixibon Blixibon merged commit c3f0509 into mapbase-source:develop Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants