Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JPEG support to dockerfile #132

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add JPEG support to dockerfile #132

merged 2 commits into from
Aug 28, 2024

Conversation

Phocacius
Copy link
Member

No description provided.

@Phocacius Phocacius requested a review from astroidex August 26, 2024 14:28
astroidex
astroidex approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@astroidex astroidex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the changes. But looks good.
maybe max_execution_time = 360 is a bit high? 6minutes?

@Phocacius
Copy link
Member Author

For some print jobs that might actually be necessary. At least two minutes was sometimes not enough.

@astroidex astroidex added this to the 4.0.1 milestone Aug 28, 2024
@Phocacius Phocacius merged commit 2f89da2 into master Aug 28, 2024
@Phocacius Phocacius deleted the work/docker-jpeg-support branch August 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astroidex astroidex astroidex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Phocacius @astroidex