Rewrite overlay types #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlay is now a protocol and its subclasses are now structs. Moved all string construction into interpolated strings in description properties. Marker and CustomMarker share a Point protocol. Renamed MarkerSize to Size and placed it under Marker. Restricted Marker.label to a new Label type that can be a Character, Int, or String. Assertions ensure valid values (although they can’t ensure valid Maki names). Renamed GeoJSON(string:) to GeoJSON(objectString:) and added a GeoJSON(object:) that takes structured data. Added documentation throughout Overlay.swift.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites Overlay.swift to be more idiomatic.
Overlay is now a protocol and its subclasses are now structs. Moved all string construction into interpolated strings in description properties. Marker and CustomMarker share a Point protocol. Renamed MarkerSize to Size and placed it under Marker. Restricted
Marker.labelto a new Label type that can be a Character, Int, or String. Assertions ensure valid values (although they can’t ensure valid Maki names). RenamedGeoJSON(string:)toGeoJSON(objectString:)and added aGeoJSON(object:)that takes structured data.Added documentation throughout Overlay.swift.