change to Platform View, add user location, simpler token #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 1, 2019
Closed
|
This is amazing @yoavrofe ! |
|
I'm going ahead and merge this. We can work out remaining todo and release when merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of the Flutter plugin using Android Platform View. This is the path Google has taken with the Webview plugin, as well as their map plugin. The performance is good, and it's east to show the user location.
iOS is not implemented in this PR, but is quite easy to implement. An example is this Implementation of the plugin by Fontinalis, which is based on the Google Maps plugin.
I believe this basic plugin can be extended to provide full support of the Mapbox GL Native map.
Since Flutter will soon support the web as well, using HummingBird, I think it will be a good idea to have the controller methods stay as close as possible to the Mapbox GL JS component.