Confirm type is a valid geojson type before finding extent #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably not sufficient: a GeoJSON Feature like {
"type": "Feature",
"properties": {
"type": "Polygon"
}
}is valid but would likely trigger the error. |
mcwhittemore
force-pushed
the
smart-type-check
branch
from
0a6fb15 to
deecd9f
Compare
|
Added this test case and switch to checking the type based off of the attributes the current value has rather than an any match. This is still a bit more liberal than the spec as this would find geojson nested inside of properties. |
|
👍 turf-bbox has mostly superseded this module but good to fix this bug in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3 and contains #4