Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communications tower #445

Merged
merged 5 commits into from
Nov 7, 2018
Merged

Communications tower #445

merged 5 commits into from
Nov 7, 2018

Conversation

natslaughter
Copy link
Contributor

closes (somewhat duplicate tickets)

#337
#257

screen shot 2018-11-01 at 5 00 37 pm

@dasulit
Copy link

dasulit commented Nov 2, 2018

Lovely @natslaughter! I really enjoy how you've made the emitting signal vertical in the 11px version to be efficient. 💓

Small comments:

  • Double-check the id and data-name metadata on your SVGs, they look to be artifacts from an earlier iteration.
  • In both versions, the middle rod seems slightly off-center relative to the top circle and bottom scaffold:

11px
screen shot 2018-11-02 at 3 38 04 pm

15px
screen shot 2018-11-02 at 3 38 07 pm

@dasulit dasulit merged commit 010792a into master Nov 7, 2018
@dasulit dasulit deleted the communications-tower branch November 7, 2018 20:32
This was referenced May 21, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasulit dasulit dasulit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natslaughter @dasulit