Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Image source example #441

Merged
merged 11 commits into from
Dec 6, 2017
Merged

Image source example #441

merged 11 commits into from
Dec 6, 2017

Conversation

langsmith
Copy link
Contributor

Adds example using image source. The same example that @asheemmamoowala added to the maps SDK test app.

Has DO NOT MERGE label because as of this writing, the example only works while using a 5.2.0-SNAPSHOT. I'll eventually merge when stable 5.2.0 is released.

ezgif com-resize

@langsmith
Copy link
Contributor Author

Fixes #437

@xilinggrantli
Copy link

How to use the 5.2.0 version? From Jcenter, it seems not to exist.

@langsmith
Copy link
Contributor Author

Hi @siazeroli , please use the 5.2.0-SNAPSHOT in your Gradle file 👇 if you'd like to view the image source example.

compile('com.mapbox.mapboxsdk:mapbox-android-sdk:5.2.0-SNAPSHOT@aar') {
        transitive = true
    }

Thanks!

@langsmith langsmith closed this Sep 4, 2017
@langsmith langsmith reopened this Sep 4, 2017
@xilinggrantli
Copy link

Yes, I tried to add it my gradle, but it told me "Error:(101, 13) Failed to resolve: com.mapbox.mapboxsdk:mapbox-android-sdk:5.2.0-SNAPSHOT". I truly want to use imagesource in my project, but 5.1.3 version does not support this class.

@langsmith
Copy link
Contributor Author

You're correct, 5.1.3 does not support this class. Please post your complete gradle file so that I can see if there are any errors.

@cammace
Copy link

cammace commented Sep 5, 2017

@siazeroli it sounds like you are missing the repository specific to SNAPSHOTs. Please add this line inside your apps build.gradle file.

maven { url "http://oss.sonatype.org/content/repositories/snapshots/" }

@xilinggrantli
Copy link

@cammace Yep, I missed it. Problem solved. Thank you!

@langsmith langsmith self-assigned this Sep 25, 2017
@langsmith langsmith removed this from the Release 5.2.0 milestone Sep 26, 2017
Copy link
Contributor

@osana osana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot compile because of duplicate strings in
title_strings.xml and string.xml

@langsmith langsmith requested review from osana and removed request for zugaldia December 5, 2017 18:51

@Override
protected void onDestroy() {
super.onDestroy();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid a crash on orientation change in tablets we should add:
if (handler != null && runnable != null) {
handler.removeCallbacks(runnable);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick on the tablet emulator. No crashing. Thanks.

ezgif com-resize

Think we're good to go on this pr

@langsmith langsmith merged commit e4333e3 into master Dec 6, 2017
@langsmith langsmith deleted the ls-image-source-example branch December 6, 2017 15:06
@langsmith langsmith mentioned this pull request Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants