Update Proguard rules #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add gms rules to location to handle issues - ignore warning during compile - keep files for run time calls
|
cc'ing to follow @langsmith |
- move proguard rules to core instead of location - add in MockLocationEngine, color, and Lost rules
- remove mocklocationengine - remove MAS dependency
- update snapshot branch - change snapshot name
electrostat
requested review from
zugaldia,
Guardiola31337,
tobrun and
LukasPaczos
and removed request for
Guardiola31337
- revert test-snapshot changes
- remove lost dependency and classes
tobrun
reviewed
Mar 12, 2018
libcore/proguard-rules.pro
Outdated
| -keep public class com.google.android.gms.* { public *; } | ||
| -dontwarn com.google.android.gms.** | ||
| -dontwarn java.awt.Color | ||
| -dontwarn com.mapzen.android.lost.api** |
There was a problem hiding this comment.
since we are removing lost from the dependencies list, we can drop this line
libcore/proguard-rules.pro
Outdated
| #-renamesourcefileattribute SourceFile | ||
| -keep public class com.google.android.gms.* { public *; } | ||
| -dontwarn com.google.android.gms.** | ||
| -dontwarn java.awt.Color |
There was a problem hiding this comment.
since we are removing mapboxServices, we can drop this line
- add proguard rules to debug section - change some rules
| # If you keep the line number information, uncomment this to | ||
| # hide the original source file name. | ||
| #-renamesourcefileattribute SourceFile | ||
| -keep public class com.google.android.gms.* { public *; } |
There was a problem hiding this comment.
Wondering if these lines are necessary 🤔
Did you see any warnings in downstream @tobrun @LukasPaczos?
There was a problem hiding this comment.
@Guardiola31337 If you take a look at mapbox/mapbox-gl-native#11417, there are a bunch of warnings from com.google.android.gms package.
This was referenced Mar 13, 2018
Merged
electrostat
added a commit
that referenced
this pull request
Mar 22, 2018
* Add GMS Rules - add gms rules to location to handle issues - ignore warning during compile - keep files for run time calls * Remove MAS dependency + MockLocationEngine - remove mocklocationengine - remove MAS dependency * Remove LOST - remove lost dependency and classes * Proguard rules in Debug and change rules - add proguard rules to debug section - change some rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in rules to handle warnings when utilizing proguard (unable to find certain play service classes) in builds