-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Perspective ratio used for circles wasn't corrected correctly. Add circle-specific regression test.
- Loading branch information
Showing
9 changed files
with
113 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-150 Bytes
(100%)
test/integration/render-tests/debug/collision-lines-pitched/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+39.9 KB
test/integration/render-tests/regressions/mapbox-gl-js#5911a/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
112 changes: 112 additions & 0 deletions
112
test/integration/render-tests/regressions/mapbox-gl-js#5911a/style.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
{ | ||
"version": 8, | ||
"metadata": { | ||
"test": { | ||
"collisionDebug": true, | ||
"debug": true, | ||
"width": 1024, | ||
"height": 2048, | ||
"description": "This is the line-label equivalent of issue #5911. The middle feature barely misses the bottom feature and barely collides with the top feature, so that the test can detect a small change in either direction. The viewport is only 1024px wide to make debug collision circles render better (issue #5941)." | ||
} | ||
}, | ||
"center": [ | ||
-10, | ||
70 | ||
], | ||
"zoom": 5, | ||
"pitch": 60, | ||
"bearing": 0, | ||
"sources": { | ||
"geojson": { | ||
"type": "geojson", | ||
"data": { | ||
"type": "FeatureCollection", | ||
"features": [ | ||
{ | ||
"type": "Feature", | ||
"properties": { | ||
"name": "First First First" | ||
}, | ||
"geometry": { | ||
"type": "LineString", | ||
"coordinates": [ | ||
[ | ||
-19.9, | ||
81.37 | ||
], | ||
[ | ||
-10, | ||
81.37 | ||
] | ||
] | ||
} | ||
}, | ||
{ | ||
"type": "Feature", | ||
"properties": { | ||
"name": "Second 2nd" | ||
}, | ||
"geometry": { | ||
"type": "LineString", | ||
"coordinates": [ | ||
[ | ||
-18, | ||
82 | ||
], | ||
[ | ||
-10, | ||
82 | ||
] | ||
] | ||
} | ||
}, | ||
{ | ||
"type": "Feature", | ||
"properties": { | ||
"name": "Third 3rd 3rd" | ||
}, | ||
"geometry": { | ||
"type": "LineString", | ||
"coordinates": [ | ||
[ | ||
-19.9, | ||
82.55 | ||
], | ||
[ | ||
-10, | ||
82.55 | ||
] | ||
] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
"glyphs": "local://glyphs/{fontstack}/{range}.pbf", | ||
"sprite": "local://sprites/sprite", | ||
"layers": [ | ||
{ | ||
"id": "background", | ||
"type": "background", | ||
"paint": { | ||
"background-color": "white" | ||
} | ||
}, | ||
{ | ||
"id": "symbol", | ||
"type": "symbol", | ||
"source": "geojson", | ||
"layout": { | ||
"symbol-placement": "line", | ||
"text-field": "{name}", | ||
"text-size": 32, | ||
"text-pitch-alignment": "viewport", | ||
"text-font": [ | ||
"Open Sans Semibold", | ||
"Arial Unicode MS Bold" | ||
] | ||
} | ||
} | ||
] | ||
} |
Binary file modified
BIN
+128 Bytes
(100%)
...render-tests/text-pitch-alignment/auto-text-rotation-alignment-map/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+128 Bytes
(100%)
.../render-tests/text-pitch-alignment/map-text-rotation-alignment-map/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.88 KB
(110%)
.../integration/render-tests/text-pitch-alignment/viewport-overzoomed/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+40 Bytes
(100%)
...er-tests/text-pitch-alignment/viewport-text-rotation-alignment-map/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
test/integration/render-tests/text-pitch-scaling/line-half/expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.