Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopgap fix for issue #5887 is missing ignoredFeatures #6004

Closed
ChrisLoer opened this issue Jan 17, 2018 · 1 comment
Closed

Stopgap fix for issue #5887 is missing ignoredFeatures #6004

ChrisLoer opened this issue Jan 17, 2018 · 1 comment
Milestone

Comments

@ChrisLoer
Copy link
Contributor

We filter out invalid results from the main collision grid, but not the ignored grid:

const thisTileFeatures = [];
const features = this.grid.query(minX, minY, maxX, maxY);
for (let i = 0; i < features.length; i++) {
// Only include results from the matching source, tile and version of the bucket that was indexed
if (features[i].sourceID === sourceID && features[i].tileID === tileID && bucketInstanceIds[features[i].bucketInstanceId]) {
thisTileFeatures.push(features[i].boxIndex);
}
}
const ignoredFeatures = this.ignoredGrid.query(minX, minY, maxX, maxY);
for (let i = 0; i < ignoredFeatures.length; i++) {
if (ignoredFeatures[i].sourceID === sourceID && ignoredFeatures[i].tileID === tileID) {
thisTileFeatures.push(ignoredFeatures[i].boxIndex);
}
}

I want to get a fuller fix for #5887 in, but we should probably get the stopgap fixed for .44.

/cc @ansis

@ChrisLoer
Copy link
Contributor Author

Fixed in #6010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant