Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels hidden under our data in 0.52.0, but not in 0.51.0 #7908

Closed
pakb opened this issue Feb 15, 2019 · 3 comments
Closed

Labels hidden under our data in 0.52.0, but not in 0.51.0 #7908

pakb opened this issue Feb 15, 2019 · 3 comments

Comments

@pakb
Copy link

pakb commented Feb 15, 2019

mapbox-gl-js version: 0.52.0

browser: Google Chrome 71.0.3578.98

Steps to Trigger Behavior

Upgrade from 0.51.0 to 0.52.0

Link to Demonstration

You can compare results on this two codepens :
0.51.0 - https://codepen.io/pakb/pen/VgErjv
0.52.0 - https://codepen.io/pakb/pen/jdeayx

As you can see south of the lake, the label Thonon-les-Bains is now hidden under our data in 0.52.0.
I don't see in the changelog anything that would hint me to what change has produced this.
Are we doing something wrong with how we describe our style or is it a bug?
(style URL : https://vectortiles.geo.admin.ch/gl-styles/ch.swisstopo.leichte-basiskarte.vt/v006/style.json)

Expected Behavior

Label not hidden under data

Actual Behavior

Label hidden under data

@pakb pakb changed the title Labels hidden under our data in 0.53.0, but not in 0.51.0 Labels hidden under our data in 0.52.0, but not in 0.51.0 Feb 15, 2019
@peterqliu
Copy link
Contributor

@pakb thanks for the report! this seems relevant to #7908, which actually prevented symbol layers under opaque fill layers to show through. Before the fix, the symbols would appear above the fill, regardless of position in the layer stack.

It's possible that your map style exploited this earlier antipattern -- can you verify that the symbol layer for your label is above the fill layer for the lake?

@ryanhamley
Copy link
Contributor

I think @peterqliu meant to reference #7612

@pakb
Copy link
Author

pakb commented Feb 18, 2019

Ok, that’s the thing.
We’ve put everything OSM before our layers. Then it’s our data which is not correctly set and not a bug, I close this issue.
Thanks for pointing me out

@pakb pakb closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants