Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10056 image migration #10060

Merged
merged 3 commits into from
Nov 3, 2020
Merged

10056 image migration #10060

merged 3 commits into from
Nov 3, 2020

Conversation

samanpwbb
Copy link
Contributor

Fix bug where legacy functions could be migrated to invalid expressions on properties with `resolvedImage` type.

cc: @mapbox/map-design-team

Closes #10056

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog></changelog>

@asheemmamoowala asheemmamoowala merged commit c602230 into main Nov 3, 2020
@asheemmamoowala asheemmamoowala deleted the 10056-image-migration branch November 3, 2020 23:10
ryanhamley pushed a commit that referenced this pull request Nov 6, 2020
@samanpwbb @ryanhamley
Correctly migrate resolvedImage type fields from legacy functions (#1…
2f4e50f 
…0060)

fix #10056
@ryanhamley ryanhamley mentioned this pull request Nov 6, 2020
Merged
ryanhamley pushed a commit that referenced this pull request Nov 6, 2020
@samanpwbb
cherry pick #10060
f6dac27 
* Correctly migrate resolvedImage type fields from legacy functions (#10060)

Co-authored-by: Saman Bemel-Benrud <samanpwbb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expression migrator generates invalid style if icon-image value is a categorical function
2 participants
@samanpwbb @asheemmamoowala