Fix data-driven property evaluation in queryRenderedFeatures

[osvodef]

Bug description

Evaluated properties returned by queryRenderedValues have the same values across the same layers, even if they are data-driven and need to be different.

JSFiddle

https://jsfiddle.net/osvodef/tj8boaxd/17/
This queries all settlement labels and outputs their text fields in the console.

Solution

This bug was due to serialized layers being cached, and multiple features of the same layer sharing the same serialized layer object. I fixed this by taking a shallow copy of the cached layer for each individual feature.

Launch Checklist

• briefly describe the changes in this PR
• manually test the debug page

[mourner]

Nicely spotted and thanks a lot for the fix! Could you also add a unit test for this to make sure this doesn't regress in future?

[osvodef]

@mourner I couldn't write a unit test ☹️ I tried adding a case to Style#queryRenderedFeatures, but those tests mock out the modified code, so it doesn't run at all.

I managed to add a query test instead that properly covers the regression and fails in main as expected.

[mourner]

Amazing, thanks so much! A query test is even better because GL Native will be tested against it as well.