Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sky - apply padding #10201

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Sky - apply padding #10201

merged 3 commits into from
Dec 14, 2020

Conversation

ivovandongen
Copy link
Contributor

@ivovandongen ivovandongen commented Dec 14, 2020 •
edited
Loading

The skybox did not have padding applied. This resulted in the horizon not lining up when padding is specified

Before:
before

After:
expected

Fixes #10185

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Apply padding to skybox</changelog>

@ivovandongen ivovandongen self-assigned this Dec 14, 2020
@ivovandongen ivovandongen changed the title Ivd sky padding Sky - apply padding Dec 14, 2020
mourner
mourner approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (nice tests!)

@ivovandongen ivovandongen merged commit 435d5a9 into main Dec 14, 2020
@ivovandongen ivovandongen deleted the ivd_sky_padding branch December 14, 2020 13:14
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@karimnaaji karimnaaji Awaiting requested review from karimnaaji

Assignees

@ivovandongen ivovandongen

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offseting vanishing point with padding does not shift the horizon properly
2 participants
@ivovandongen @mourner