Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unproject not working for -ve y values #10224

Merged
merged 6 commits into from
Dec 22, 2020
Merged

Fix unproject not working for -ve y values #10224

merged 6 commits into from
Dec 22, 2020

Conversation

arindam1993
Copy link
Contributor

@arindam1993 arindam1993 commented Dec 17, 2020 •
edited
Loading

Fixes #10215.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix a bug wherein map.panBy() would not pan the map equally in both directions.</changelog>

@arindam1993 arindam1993 mentioned this pull request Dec 17, 2020
Closed
6 tasks
mourner
mourner approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this works better — let's fill out the PR description and add a unit test and we're good.

karimnaaji
karimnaaji approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@karimnaaji karimnaaji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % unit tests, nice catch on this corner case @arindam1993

@arindam1993 arindam1993 changed the base branch from fix-unproject-2d to main December 21, 2020 23:58
@arindam1993 arindam1993 changed the title Add option for unclamped horizon from top Fix unproject not working for -ve y values Dec 22, 2020
@arindam1993 arindam1993 merged commit 28a029e into main Dec 22, 2020
@arindam1993 arindam1993 deleted the arindam/fix-unproject-2d branch December 22, 2020 00:24
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karimnaaji karimnaaji karimnaaji approved these changes

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map.unproject doesn't handle points with negative y in 2D mode
3 participants
@arindam1993 @mourner @karimnaaji