Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10033 #10284

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Fix #10033 #10284

merged 1 commit into from
Jan 23, 2021

Conversation

karimnaaji
Copy link
Contributor

@karimnaaji karimnaaji commented Jan 13, 2021

Fixes two different artifacts when using patterns with data driven styling.

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix inconsistent behavior of patterns while using data driven styling</changelog>

@arindam1993
Copy link
Contributor

LGTM!

capturing the in-person discussion we had:

There seem to be 2 issues

  1. For data-driven pattern props, the vertex buffer was getting populated with data incorrectly. This PR addresses that
  2. For data-constant zoom-dependent pattern props, the evaluation of patternDependencies here does not account for the 3 zoom levels (z-1, z, z+1)at which the expression must be evaluated in order to have proper crossfading both in and out. This is not an issue with data-driven patterns because those three states are evaluated here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patterns computed from zoom-based expressions render with incorrect scale
2 participants