Flickering geolocate circle fix #10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mourner
approved these changes
Feb 1, 2021
|
Brilliant fix, thanks for taking on this! Just in case, could you also add a test in |
anderswi
force-pushed
the
geolocate_flicker
branch
from
642e7ad
to
aa52342
Compare
|
@mourner I've added tests now. I never got the testing to work properly locally (on windows), but the ci tests are passing now and should™ fail without my fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10276
The metersPerPixel calculation introduced rounding errors. By measuring over 100 pixels instead of 1 pixel, the issue goes away.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix for flickering accuracy circle in GeolocateControl.</changelog>