Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Mapbox logo when no style is provided #10361

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Conversation

ryanhamley
Copy link
Contributor

@ryanhamley ryanhamley commented Feb 6, 2021

Launch Checklist

  • briefly describe the changes in this PR
    • Show Mapbox logo if no style is provided
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Show Mapbox logo if not style is provided for the map</changelog>

Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge pending a unit/other test.

@ryanhamley ryanhamley merged commit 43c38d3 into main Feb 11, 2021
@ryanhamley ryanhamley deleted the show-logo-with-no-style branch February 11, 2021 23:29
@karimnaaji karimnaaji added this to the v2.2 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants