Add a testMode Map option to allow for usage in tests without an access token
#10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 12, 2021 12:22
# Conflicts: # src/terrain/draw_terrain_raster.js
- Switch name to testMode - Migrate Selenium browser tests to use testMode
karimnaaji
reviewed
Mar 9, 2021
karimnaaji
reviewed
Mar 9, 2021
rreusser
approved these changes
Mar 9, 2021
karimnaaji
approved these changes
Mar 9, 2021
TrySound
reviewed
May 30, 2021
| @@ -104,6 +104,7 @@ type MapOptions = { | |||
| maxTileCacheSize?: number, | |||
| transformRequest?: RequestTransformFunction, | |||
| accessToken: string, | |||
| testMode: ?boolean, | |||
There was a problem hiding this comment.
Shouldn't it be optional, not just nullable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Mapconstructor option calledtestMode. When enabled it allows for the usage of the map in automated tests without an accessToken with custom self-hosted test fixtures.In this mode, the Map produces no rendered output on the canvas, but still retains all state for features and the camera. This means mocked mouse and UI events will work as expected.
In order to "test" the
testModeI migrated our unit and selenium tests to use it, and removed the custom access tokens that were hardcoded in there.Launch Checklist
mapbox-gl-jschangelog:<changelog></changelog>