Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for sourceId to MapDataEvent #10830

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Add documentation for sourceId to MapDataEvent #10830

merged 3 commits into from
Jul 15, 2021

Conversation

domlet
Copy link
Contributor

@domlet domlet commented Jul 9, 2021

Closes #9164

  • Add documentation for sourceId to MapDataEvent

Launch Checklist

  • briefly describe the changes in this PR
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@domlet domlet added docs 📜 skip changelog Used for PRs that do not need a changelog entry labels Jul 9, 2021
@domlet domlet force-pushed the sprint/sourceId branch from cfcd01b to 13875e6 Compare July 13, 2021 18:14
@domlet domlet force-pushed the sprint/sourceId branch from 13875e6 to b2f36b6 Compare July 13, 2021 18:15
@domlet domlet requested review from ansis and HeyStenson July 13, 2021 18:16
@domlet domlet marked this pull request as ready for review July 13, 2021 18:16
@domlet domlet requested review from danswick and removed request for HeyStenson July 13, 2021 18:16
@domlet domlet merged commit dd0aad4 into main Jul 15, 2021
@domlet domlet deleted the sprint/sourceId branch July 15, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

@ansis ansis Awaiting requested review from ansis

@danswick danswick Awaiting requested review from danswick

Assignees
No one assigned
Labels
docs 📜 skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MapDataEvent documentation missing sourceid
2 participants
@domlet @asheemmamoowala