Adjust queryRenderedSymbols with tile perspective approximation #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of symbol perspective ratio.
- Cover more tiles - Include features whose collision box only partially intersects query geometry - Add text to the features (making the features bigger makes pitch-scaling easier to test) - Ignore on native until pitch scaling changes go in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back-port from mapbox/mapbox-gl-native#9009. Although
queryRenderedSymbolswon't match collision boxes exactly (because they're partially calculated in the GPU), this change gets the results ofqueryRenderedSymbolscloser to what's shown on the screen by using the tile-based approximation of the pitch-scaling ratio.To get an idea for what this changes, look at the
actual.pnggenerated forquery/symbol-features-in/pitched-screen. Before the change, the top symbol wouldn't be included in the results (even though you can see the rendered collision box overlaps with the query geometry).@ansis