New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aria-label to Popup close button #4799

Merged

mourner merged 1 commit into master from popup-close-arialabel

Jun 7, 2017

Collaborator

andrewharvey commented Jun 7, 2017

This change ensures screen readers etc. read this as a close popup button rather than a multiplication sign.

Launch Checklist

briefly describe the changes in this PR
write tests for all new functionality
document any changes to public APIs
post benchmark scores
manually test the debug page


          add aria-label to Popup close button

c1a4554

mourner approved these changes

View reviewed changes

mourner merged commit 84cc4a9 into master

mourner deleted the popup-close-arialabel branch

June 7, 2017 14:20

jmunowitch mentioned this pull request

Upgrade to Mapbox-gl-js 0.40.0 archesproject/arches#2410

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet