Clip raster tiles #5105
Merged
Clip raster tiles #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
force-pushed
the
clip-raster
branch
2 times, most recently
from
58c2254
to
01ce24f
Compare
5 tasks
mollymerp
force-pushed
the
clip-raster
branch
3 times, most recently
from
b524ea0
to
c87a92d
Compare
mollymerp
force-pushed
the
clip-raster
branch
from
c87a92d
to
9095b3e
Compare
mollymerp
force-pushed
the
clip-raster
branch
from
b0cba75
to
2f07a46
Compare
|
This is ready for review @kkaefer – I removed the depth testing per #5119 (comment) |
19 tasks
mollymerp
force-pushed
the
clip-raster
branch
from
2f07a46
to
c1efd53
Compare
kkaefer
approved these changes
Sep 18, 2017
src/source/tile.js
Outdated
| @@ -67,8 +71,10 @@ class Tile { | |||
| placementSource: any; | |||
| workerID: number; | |||
| vtLayers: {[string]: VectorTileLayer}; | |||
|
|
|||
| mask: Array<number>; | |||
There was a problem hiding this comment.
Can we create an alias for this?
There was a problem hiding this comment.
...and could we potentially use ES6's Set for this?
There was a problem hiding this comment.
I decided to use an object to avoid precarious IE11 compatibility with Set
test/unit/source/tile_mask.test.js
Outdated
| t.test('deep descendent masks', (t)=>{ | ||
| const renderables = [ new Tile(0, 0, 0), new Tile(4, 4, 4)]; | ||
| updateTileMasks(renderables); | ||
| t.deepEqual(renderables.map((r)=>{ return r.mask; }), [ [2, 34, 130, 2212, 2692, 2724, 611, 835, 867, 33, 65, 97], [0]]); |
There was a problem hiding this comment.
Instead of using numeric IDs here, can we please use TileCoord(z, x, y).id to make this more readable and comparable with Native?
src/render/tile_mask.js
Outdated
| // │ │ │ | ||
| // └─────────────────┴─────────────────┘ | ||
| // | ||
| // Only other renterable tiles that are *children* of the tile we are generating the mask for will |
added 10 commits
September 19, 2017 18:07
fix doc lint
fix bugs in the masking algorithm perform masking on raster tile loads clean up
clean up PR
mollymerp
force-pushed
the
clip-raster
branch
from
c1efd53
to
c72d9c0
Compare
mollymerp
force-pushed
the
clip-raster
branch
from
c72d9c0
to
69a347b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS counterpart to mapbox/mapbox-gl-native#9468
I still need to port mapbox/mapbox-gl-native#8769 and mapbox/mapbox-gl-native#8164 ( ticked #4257 ) in order for gl-js to actually request the tiles needed in order for the raster-masking render test to pass.
cc @kkaefer
Launch Checklist