Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double draw in render-tests #5199

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Conversation

asheemmamoowala
Copy link
Contributor

Move text and camera off tile boundaries to prevent double drawing of symbols.

In support of passing tests in gl-native port

Chris Loer @asheemmamoowala The double-drawing is actually a larger underlying bug that I think we should address, but for now with the test, the right approach might be to just make it irrelevant by shifting the labels so they’re not near a tile boundary and thus don’t get double-drawn

Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Here's the relevant issue that these tests are interacting with: #2706

/cc @nickidlugash

@ChrisLoer
Copy link
Contributor

It would be interesting to know why the double-drawing isn't happening in gl-native -- I thought the logic was the same.

@asheemmamoowala asheemmamoowala merged commit 41c6ce1 into master Aug 28, 2017
@asheemmamoowala asheemmamoowala deleted the off-center-symbols-test branch August 28, 2017 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants