Fix geojson Position element issue (3rd element) #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguiter
changed the title
|
Thanks @oguiter! Could you please add a test for this? |
oguiter
added a commit
to oguiter/mapbox-gl-js
that referenced
this pull request
Nov 7, 2017
Test LatLng convert on GeoJSON Position with Elevation Signed-off-by: Olivier Guiter <oguiter@free.fr>
|
Hi @jfirebaugh, |
oguiter
added a commit
to oguiter/mapbox-gl-js
that referenced
this pull request
Nov 8, 2017
Test LatLng convert on GeoJSON Position with Elevation Signed-off-by: Olivier Guiter <oguiter@free.fr>
jfirebaugh
force-pushed
the
master
branch
2 times, most recently
from
95743aa
to
24a7b1b
Compare
Following RFC 7946, position is an array of number with two OR MORE elements (Implementations SHOULD NOT extend positions beyond three elements). The 3rd element is usually Altitude. We could ignore it but we must not fail. This small fix allows well-formed geojson file to be fully processed Signed-off-by: Olivier Guiter <oguiter@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following RFC 7946, position is an array of number with two OR MORE
elements (Implementations SHOULD NOT extend positions beyond three
elements). The 3rd element is usually Altitude. We could ignore it
but we must not fail.
This small fix allows well-formed geojson file to be fully processed
Signed-off-by: Olivier Guiter oguiter@free.fr
Launch Checklist